Code I Found: A Warning about Object Comparisons

Fri, 27 Aug 2010 14:24:00 -0500

Last time I posted a "Code I Found" entry some people got upset... well I'm doing it again, but I'm pairing it with an actual warning about object value comparisons in strongly typed languages. This example shows both a valid problem and some dumb coding that complicates it. [More]

Code I Found

Tue, 15 Jun 2010 16:24:00 -0500

Its time for a new category here on my blog... I've been working through a good bit of older code at work and trying to update it to something like modern developer standards. Part of the fun of this has been finding weird, pointless language constructs. Check out this C# example:

if (IsEditable(ID))
	EnableEditButtons(true);
else
	EnableEditButtons(false);

Neat! This developer was able to use 4 lines of code to do one line of code: EnableEditButtons(IsEditable(ID)); Do you have any good examples of code that just shouldn't have been?

Update!

The EnableEditButton() function from the last example is worth a look too...

protected void EnableEditButtons(bool Value)
{
	if (Value == false)
	{
		buttonAdd.Disabled = true;
		buttonDelete.Disabled = true;
	}
	else
	{
		buttonAdd.Disabled = false;
		buttonDelete.Disabled = false;
	}
}

Could be wrapped up as:

protected void EnableEditButtons(bool Value)
{
	buttonAdd.Disabled = buttonDelete.Disabled = !Value;
}

Jon Hartmann - C#

Code I Found: A Warning about Object Comparisons

Code I Found

Update!